search

pangeo-forge / pangeo-forge-orchestrator

Database API and GitHub App backend for Pangeo Forge Cloud.
https://api.pangeo-forge.org/docs
Apache License 2.0
4 stars 1 forks source link

Derive dataset type from recipe object (rather than hardcoding) #199

Closed cisaacstern closed 10 months ago

cisaacstern commented 1 year ago

Now that @andersy005 completed https://github.com/pangeo-forge/pangeo-forge-recipes/pull/437, we can actually do this:

https://github.com/pangeo-forge/pangeo-forge-orchestrator/blob/fb5caaf6994d1b73004b447ab00e5687ab941f2e/pangeo_forge_orchestrator/routers/github_app.py#L882-L884

The hardcoding of dataset_type needs to be changed in two places:

  1. https://github.com/pangeo-forge/pangeo-forge-orchestrator/blob/fb5caaf6994d1b73004b447ab00e5687ab941f2e/pangeo_forge_orchestrator/routers/github_app.py#L894
  2. https://github.com/pangeo-forge/pangeo-forge-orchestrator/blob/fb5caaf6994d1b73004b447ab00e5687ab941f2e/pangeo_forge_orchestrator/routers/github_app.py#L1216

198 will require this fix to actually work.