search

pangeo-forge / pangeo-forge-orchestrator

Database API and GitHub App backend for Pangeo Forge Cloud.
https://api.pangeo-forge.org/docs
Apache License 2.0
4 stars 1 forks source link

In synchronize, close check runs for all subprocess.CalledProcessErrors #97

Closed cisaacstern closed 2 years ago

cisaacstern commented 2 years ago

Thanks to @andersy005 for noticing this issue and inquiring why the GitHub App was leaving check runs unclosed; https://github.com/pangeo-forge/pangeo-forge-orchestrator/pull/95#issuecomment-1240015145 summarizes the underlying problem.

To fix this, we should be patching the check run inside the else block here (as is done for the if block above it):

https://github.com/pangeo-forge/pangeo-forge-orchestrator/blob/2b37019e86a9aa31e0151ea340c9df09fabf0174/pangeo_forge_orchestrator/routers/github_app.py#L663-L678

The output field here could be something like:

    output=dict(title="Unexpected synchronize error", summary=tracelines[-1]),
cisaacstern commented 2 years ago

xref https://github.com/pangeo-forge/staged-recipes/pull/176#issuecomment-1242521805

cisaacstern commented 2 years ago

https://github.com/pangeo-forge/staged-recipes/pull/162 is currently blocked by this. The synchronize task is hanging there, and without a trace for the called process error it's unclear why. Edit: This is probably because pangeo-forge-esgf is not yet available in production.