pangeo-gallery / default-binder

Default binder environment for pangeo gallery.
5 stars 5 forks source link

Dask labextension does not work in latest images #21

Closed rabernat closed 3 years ago

rabernat commented 3 years ago

Pasting the dashboard link into the Dask labextension dialog has no effect. It does not recognize the link, and none of the buttons become active. I have tried this on several recent

image

For example, here is a link for our classic example notebook using the latest commit of this repo (64d772a), which points to the latest pangeo-notebook docker image (c8c0d72).

https://binder.pangeo.io/v2/gh/pangeo-gallery/default-binder/64d772a/?urlpath=git-pull?repo=https://github.com/pangeo-gallery/physical-oceanography%26amp%3Burlpath=lab/tree/physical-oceanography/01_sea-surface-height.ipynb%3Fautodecode

What extra config are we missing to make the labextension work? It DOES work in https://us-central1-b.gcp.pangeo.io/, so something must be missing here. Something also must have changed since earlier versions, but I can't pinpoint the precise commit where things broke.

cc @scottyhq @TomAugspurger for any suggestions!

jbusecke commented 3 years ago

I am having the same issue. It especially impacts the way I can give interactive demos during presentations (leading to error-prone and distracting switching between windows).

Is there any way we can fix this? Happy to help out in any way I can.

TomAugspurger commented 3 years ago

First thing to check would be the javascript console in your browser (typically under “Developer tools”). Are there any errors there?

On Jan 8, 2021, at 4:13 PM, Julius Busecke notifications@github.com wrote:

I am having the same issue. It especially impacts the way I can give interactive demos during presentations (leading to error-prone and distracting switching between windows).

Is there any way we can fix this? Happy to help out in any way I can.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pangeo-gallery/default-binder/issues/21#issuecomment-757025183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAOIR5CCSNREM2S6665U3SY57RZANCNFSM4VZDZWOQ.

rabernat commented 3 years ago

No, didn't get any errors in my JavaScript console.

rabernat commented 3 years ago

I think we should closely examine the difference between the gcp deployment and the binders to figure this out.

rabernat commented 3 years ago

I think we should closely examine the difference between the gcp deployment and the binders to figure this out.

The only difference is the version of the image: https://github.com/pangeo-gallery/default-binder/blob/64d772acdb0c35f5800f2733cfad3cf5447dec8f/binder/Dockerfile#L1

vs

https://github.com/pangeo-data/pangeo-cloud-federation/blob/staging/deployments/gcp-uscentral1b/image/binder/Dockerfile#L1

rabernat commented 3 years ago

I'm going to close this in favor of https://github.com/pangeo-data/pangeo-docker-images/issues/177, since I think it is ultimately about package versions.