added color - Githubissues

panglesd / diffcessible

MIT License

17 stars 13 forks source link

added color #48

Closed ademolaomosanya closed 6 months ago

ademolaomosanya commented 8 months ago

fixes #5 this pr fixes Add colors to output #5

panglesd commented 8 months ago

Two comments:

Could you rebase with the latest changes on main? You are using a pretty old version!
It would be better to use the Notty attributes to colorize rather than the Ansi library. Feel free to take the newest changes as inspiration!

ademolaomosanya commented 8 months ago

Two comments:

Could you rebase with the latest changes on main? You are using a pretty old version!

It would be better to use the Notty attributes to colorize rather than the Ansi library. Feel free to take the newest changes as inspiration!

okay thank you i will do that

yokurang commented 6 months ago

No progress for a while. I suggest closing the PR @Julow / @panglesd ?

yokurang commented 6 months ago

Already fixed in PR https://github.com/panglesd/diffcessible/pull/57

panglesd commented 6 months ago

Thanks anyway @ademolaomosanya for your work on this!