panglesd / diffcessible

MIT License
17 stars 13 forks source link

Updated the implementation for hscroll area #56

Open maha-sachin opened 8 months ago

maha-sachin commented 8 months ago

@panglesd @Julow , I've encountered a bug in the scroll area implementation and would appreciate your guidance in resolving it.

When using a vscroll area inside hscroll area, I've noticed that the horizontal scrolling behaves correctly with the left and right keys. However, there's an issue with vertical scrolling – when using the up and down keys, the behavior is unexpected, and vice versa.

And, Currently, we're planning to implement vertical scrolling using the j and k keys. I propose extending this functionality to include horizontal scrolling as well, by introducing the v and b keys for scrolling left and right, respectively. With these additional keys, users would have a more comprehensive navigation experience, allowing them to scroll both vertically and horizontally with ease.

vertical scroll:
| `ASCII 'j', [] -> scroll state (-scroll_step)  
| `ASCII 'k', [] -> scroll state (+scroll_step)

horizontal scroll:
| `ASCII 'v', [] -> scroll state (-scroll_step)  
| `ASCII 'b', [] -> scroll state (+scroll_step)

What are your thoughts on incorporating horizontal scroll keys v and b? I am looking forward to hearing your feedback. Thank you very much for your assistance and support in tackling this issue.