Pangochef update

[Shungy]

• Fix non-reverting calls:

  • try/catch revert on incorrect return value,
  • call can revert due to gas griefing with long return values,
  • only assembly level call, or try/catch with helper contract can be safe,
  • gas griefing at the end of the execution is not an issue due to EIP-150 which says 1/64 of the gas is not forwarded.

• Replace compoundToPoolZero with compoundTo

  • Can compoundTo any pool that is a PGL pair with PNG as one of the reserve tokens,
  • Cannot call compoundTo on a pool that can compound itself.

• Other interface changes:

  • User.lockCount (uint56) replaces User.isLockingPoolZero (uint8): User can exit from the pool only if lockCount is zero.
  • New method function getLockedPools(uint256 poolId, address userId) external view returns (uint256[] memory); can be used to get the list of pools that the poolId is locking.

[sonarcloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
30.8% Duplication