pangtao22 / planning_through_contact

MIT License
41 stars 7 forks source link

Fix the planar hand and pushing examples #59

Closed aykut-tri closed 1 year ago

aykut-tri commented 1 year ago

This PR proposes two small fixes for the following issues:


This change is Reviewable

aykut-tri commented 1 year ago

Sure thing. I also guessed irs_mpc2 would make irs_mpc obsolete at some point but it was a super easy fix, so I wanted to push it regardless.

The run_planar_pushing2 example was failing because h was not set in the irs_mpc2 parameters, and it is NaN by default. Also, publish_trajectory at the end was not working since h is not passed. So, I just fixed those two issues in the example script.

aykut-tri commented 1 year ago

Gotcha, I'll let you guys decide on whether to merge this PR. I just wanted to record the issue/solution in case our future selves or other current users want to run the planar examples out of the box.

pangtao22 commented 1 year ago

closed by #61