pangtao22 / planning_through_contact

MIT License
41 stars 7 forks source link

Deprecate old API. #61

Closed pangtao22 closed 1 year ago

pangtao22 commented 1 year ago

Remove things like QuasistaticDynamics, whose functionality has been largely absorbed by QuasistaticSimulatorCpp and QuasistaticVisualizer.


This change is Reviewable

pangtao22 commented 1 year ago

Important note for all Allegro contact samplers: The ordering of the joints using the new sdf (in the models directory of quasistatic_simulator), which is consistent with Allegro's ROS driver, is different from the joint ordering in drake's allegro sdf (found in drake/manipulation/models), which is what we've been using for the June 2022 version of the paper.

The mapping between from the old ordering to the new ordering is reproduced below for convenience:

Index Finger Thumb Middle Finger Ring Finger
Old (Drake) 0, 1, 2, 3 4, 5, 6, 7 8, 9, 10, 11 12, 13, 14, 15
New (Ours) 0, 1, 2, 3 12, 13, 14, 15 4, 5, 6, 7 8, 9, 10, 11
pangtao22 commented 1 year ago

Another important note for contact samplers: the input to ContactSampler.sample_contact(...) has been changed to the configuration of the entire system ('q'), not just the configuration of the object (q_u).

pangtao22 commented 1 year ago

A TODO list for converting examples to use the new API

pangtao22 commented 1 year ago

BundleMode, an enumeration defined in iRS-MPC, is still used by iRS-RRT. It needs to be removed. https://github.com/pangtao22/planning_through_contact/blob/038b4c1acfd24b6f0e0e420b0f0d49ea63770b82/irs_mpc/irs_mpc_params.py#L4

pangtao22 commented 1 year ago

BundleMode has been removed.