search

panichelpdesk / panichd

Ticketing system for Laravel 5.1 - 8.x. Allows to create new tickets via form only. Includes file attachments, ticket tags, filtering, scheduling and e-mail notifications.
MIT License
90 stars 41 forks source link

add Models\ User to fit Laravel 8 #31

Closed ramirors closed 3 years ago

ramirors commented 3 years ago

As we know in L8, User model is located in Models folder.

xaviqv commented 3 years ago

Hello @ramirors,

Thanks for your feedback.

PanicHD is still using App\User because at the moment we're keeping compatibility with Laravel installations that can be using laravel/ui since earlier versions of the framework. laravel/ui is also compatible with Laravel 8. There also may exist other third party user auth packages that also make use of "App\User" namespace.

So, to keep these backward compatibilities, I guess that changing the parent classname for PanicHD Member model is not a correct approach.

As of issue #28 I noticed about the problem originated in PanicHD with a fresh Laravel 8 installation using Laravel Breeze, which is In fact one of the recommended auth packages in Laravel 8. In these kind of installations, auth is using App\Models\User as you have pointed out. In that issue, I posted a manual patch for these kind of installations. Anyway, since then I'm also working on a patch that makes PanicHD compatible with both namespaces.

xaviqv commented 3 years ago

Hello @ramirors,

I have just published a new PanicHD release. Now PanicHD should be natively compatible with Laravel apps using App\Models\User. Check it out! https://github.com/panichelpdesk/panichd/releases/tag/v0.21.0

ramirors commented 3 years ago

Yeah!! Thanks !

El dom., 28 de febrero de 2021 12:51, Xavi notifications@github.com escribió:

Hello @ramirors https://github.com/ramirors,

I have just published a new PanicHD release. Now PanicHD should be natively compatible with Laravel apps using App\Models\User. Check it out! https://github.com/panichelpdesk/panichd/releases/tag/v0.21.0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/panichelpdesk/panichd/pull/31#issuecomment-787501713, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB7MVAUQQ7CFJW2VCMQCLDTBKGDRANCNFSM4YBFZNMQ .