panicinc / icarus

Swift, C, C++, and Objective-C Support for Nova
MIT License
69 stars 5 forks source link

Escaped Character highlighting support inside string literals. #13

Open EmranMR opened 9 months ago

EmranMR commented 9 months ago

Hello! This pull request adds highlighting support for escape characters. Currently Nova does not have a specific theming selector for these characters like the regex.escaped, or the string.escape that was written in objc/highlights.scm

I followed your convention of using @value.number for char values, so that the theming is consistent across.

PS. I am very new to C family programming language and barely touched the surface with C++. I gave it a shot myself in all the languages and it seem to work fine. However I found a parsing bug 🐞 while I was testing, very likely due to core Nova, Unrelated to this extension or tree-sitter 🌳 and I will raise it via the form on Nova.app. Other than that it worked as expected on my side! 😊

Screenshot 2023-09-30 at 11 38 08

👇👇👇👇👇👇

Screenshot 2023-09-30 at 11 38 22