panifie / PingPong.jl

Cryptocurrency trading bot, and backtesting framework in julia
https://panifie.github.io/PingPong.jl/
GNU General Public License v3.0
48 stars 10 forks source link

bn.binancedownload() failed. #47

Closed janckerchen closed 3 months ago

janckerchen commented 3 months ago

The fix(#46) has introduced new issues. The previously working download function has stopped working.

julia> using Scrapers: Scrapers as scr, BinanceData as bn

julia> bn.binancedownload("eth", market=:data, freq=:monthly, kind=:klines)

┌ Warning: XMLError: Tag nav invalid from HTML parser (code: 801, line: 8)
└ @ EzXML ~/.julia/packages/EzXML/DL8na/src/error.jl:97
┌ Warning: XMLError: Tag svg invalid from HTML parser (code: 801, line: 17)
└ @ EzXML ~/.julia/packages/EzXML/DL8na/src/error.jl:97
┌ Warning: XMLError: Tag path invalid from HTML parser (code: 801, line: 18)
└ @ EzXML ~/.julia/packages/EzXML/DL8na/src/error.jl:97

┌ Warning: binance: download failed (or up to date)
│   sym = "ETHUSDT"
│   last_file = nothing
panbonker commented 3 months ago

it should mean that the downloaded data is up to date, currently the module doesn't do a more robust check for errors, but you can verify it from what data binanceload returns, since the archives are updated monthly, now you should have up to the end of may

janckerchen commented 3 months ago

remove cache can fixed. It might be that yesterday's download status(with bug) caused the issue.

rm -rf ~/.cache/PingPong