panique / huge

Simple user-authentication solution, embedded into a small framework.
2.14k stars 788 forks source link

Changed max lenght of email address #832

Closed arjove closed 7 years ago

arjove commented 7 years ago

I would like to suggest changing the max lenght of the email field in the database.

Since its provided in this stackoverflow post that emails can at max be 254 chars long.

After checking against the local php filter in the Registratonmoddel::validateUserEmail() we do not check the length of the email before its added to the database. (which could result in a failed user creation without giving back a proper error.)

arjove commented 7 years ago

Wether or not this is the proper way to do it, you could also add a check within validateUserEmail, which would limit to 64 chars.

panique commented 7 years ago

Hi, big thanks! This project has reached End Of Life, so it's not developed anymore, but i'll will merge this anyway as it's a small and nice chance.