search

panique / mini2

Just an extremely simple naked PHP application, useful for small projects and quick prototypes.
MIT License
417 stars 102 forks source link

[TODO] What about using .env #43

Closed fede closed 8 years ago

fede commented 8 years ago

We are using this framework for a small development but we have modified the index.php to use an .env with https://github.com/vlucas/phpdotenv Since we use git for our deployments we think it's safer not to store passwords from different environments in the same file, so .env it's actually ignored on git and there's one in every environment. I have forked the repo and I can commit this change to pull request but I wanted to know if someone is actually interested in this change.

dezudas commented 8 years ago

this change sound interesting, please go ahead

panique commented 8 years ago

Sound reeeally good, but as the concept of this repo is to "make it run out of the box as simple as possible" it might be a little bit too complex to make it work with .env files from the beginning (as users would have to add more steps to get things to run). Maybe you could add the logic to the readme file somehow, there's a block called useful, so users can add this if needed.

But that's just my personal opinion... :)

Thanks for commiting to the project! Very welcome!