panique / mini3

Just an extremely simple naked PHP application, useful for small projects and quick prototypes.
274 stars 100 forks source link

Pull 61 wasn't applied to the develop branch. #70

Closed BeardyMike closed 9 months ago

BeardyMike commented 9 months ago

https://github.com/panique/mini3/pull/61

This pull was applied to the MASTER branch, but not the DEVELOP branch.

The pull is a fantastic feature, and it makes sense that the DEVELOP branch should have it as well.

If there's something I'm missing, please let me know as I can't figure out why it wasn't applied to both....

BeardyMike commented 9 months ago

I've made pull request with the changes. That feels like a better place to give objections, and hash out reasoning.

panique commented 8 months ago

hey @BeardyMike , thanks for your eye for the detail, nice one! I just checked and it seems that over the years several changes have been made to different branches of the projects, but not in sync, so we now have some problems (see the screenshots below please). Also, the tutorial and the README have not been updated in some cases.

Right now i'm too busy to do this, I i would say: let's keep this on hold, I'll check back later ;)

Bildschirmfoto 2024-02-20 um 22 02 48 Bildschirmfoto 2024-02-20 um 22 02 40