bug:aviod int overflow - Githubissues

matyle commented 1 year ago

name: Pull request about: Propose changes to the code title: '' labels: '' assignees: ''

1. Are you opening this pull request for bug-fixs, optimizations or new feature?

2. Please describe how these code changes achieve your intention.

3. Please link to the relevant issues (if any).

4. Which documentation changes (if any) need to be made/updated because of this PR?

4. Checklist

[x] I have squashed all insignificant commits.
[x] I have commented my code for explaining package types, values, functions, and non-obvious lines.
[x] I have written unit tests and verified that all tests passes (if needed).
[x] I have documented feature info on the README (only when this PR is adding a new feature).
[x] (optional) I am willing to help maintain this change if there are issues with it later.

panjf2000 commented 1 year ago

Why do we need this code change when we've already resolved the overflow issue?

matyle commented 1 year ago

Why do we need this code change when we've already resolved the overflow issue? The previous method may overflow if l, r are negative numbers. Although the function call is impossible, I think the previous method is too tricky, and frequent calls to cast twice will cause performance loss, thank you

panjf2000 commented 1 year ago

I appreciate your effort but we should not spend too many tricks on this overflow case, considering it's a minimal probability and the current resolution is good enough, visit this for more details.

P.S. The current implementation is taken from sort.

panjf2000 / ants

bug:aviod int overflow #289