search

panjf2000 / gnet

🚀 gnet is a high-performance, lightweight, non-blocking, event-driven networking framework written in pure Go.
https://gnet.host
Apache License 2.0
9.7k stars 1.04k forks source link

feat: add DialContext and EnrollContext for Client #543

Closed leslie-fei closed 8 months ago

leslie-fei commented 8 months ago

Fixes #541

leslie-fei commented 8 months ago

都改掉提交了

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.00%. Comparing base (f6b0d30) to head (fa1e739). Report is 6 commits behind head on dev.

Files Patch % Lines
client_unix.go 83.33% 1 Missing :warning:
client_windows.go 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #543 +/- ## ========================================== - Coverage 79.12% 79.00% -0.12% ========================================== Files 25 25 Lines 2074 2091 +17 ========================================== + Hits 1641 1652 +11 - Misses 299 304 +5 - Partials 134 135 +1 ``` | [Flag](https://app.codecov.io/gh/panjf2000/gnet/pull/543/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andy+Pan) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/panjf2000/gnet/pull/543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andy+Pan) | `79.00% <86.66%> (-0.12%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andy+Pan#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

leslie-fei commented 8 months ago

存在的几个data race问题我也修复了下

panjf2000 commented 8 months ago

你本地测过了没有？

leslie-fei commented 8 months ago

测过了

leslie-fei commented 8 months ago

改过了, 你看看