search

panjf2000 / gnet

🚀 gnet is a high-performance, lightweight, non-blocking, event-driven networking framework written in pure Go.
https://gnet.host
Apache License 2.0
9.69k stars 1.04k forks source link

opt: close file descriptor after OnClose() #622

Closed panjf2000 closed 4 months ago

panjf2000 commented 4 months ago

Fixes #621

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.76%. Comparing base (8a80aaf) to head (b7aef26).

Files Patch % Lines
eventloop_unix.go 28.57% 9 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #622 +/- ## ========================================== - Coverage 80.89% 80.76% -0.13% ========================================== Files 21 21 Lines 2109 2116 +7 ========================================== + Hits 1706 1709 +3 - Misses 273 276 +3 - Partials 130 131 +1 ``` | [Flag](https://app.codecov.io/gh/panjf2000/gnet/pull/622/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andy+Pan) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/panjf2000/gnet/pull/622/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andy+Pan) | `80.76% <28.57%> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andy+Pan#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.