panjiwa10028 / solr-php-client

Automatically exported from code.google.com/p/solr-php-client
Other
0 stars 0 forks source link

Apache_Solr_Response does not implement __isset #35

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Attempt to verify if faceting information is present, e.g.
isset($response->facet_counts)
2. This returns false always, as facet_counts is generated via that __get()
magic method

What is the expected output? What do you see instead?

I expect that isset($response->facet_counts) would return true if facet
counts are present; this would imply that checking isset parses the data
and returns an appropriate isset() on the parsed data.

What version of the product are you using? On what operating system?

Current head.

Please provide any additional information below.

Note that this affects things like highlighting as well.  The same solution
(implementing __isset(), in which the data is parsed and then checked)
would fix this too.

Original issue reported on code.google.com by liam.obo...@gmail.com on 18 Feb 2010 at 7:09

GoogleCodeExporter commented 8 years ago
__isset implementation committed in revision 29

Original comment by donovan....@gmail.com on 19 Feb 2010 at 11:48