Apache_Solr_Service::commit() misses an $expungeDeletes parameter

[GoogleCodeExporter]

Hi,

Regarding commits, there is an "expungeDeletes" option (which is false by 
default) thanks to which documents deleted using for instance 
Apache_Solr_Service::deleteById() are actually deleted from the index. But 
currently, Apache_Solr_Service::commit() doesn't provide a method for using 
this "expungeDeletes" option.
The doc about the "expungeDeletes" option I'm talking about can be found here: 
http://wiki.apache.org/solr/UpdateXmlMessages#A.22commit.22_and_.22optimize.22

Here is a patch which adds a $expungeDeletes parameter to 
Apache_Solr_Service::commit() ...

Cheers, and thanks for your work...

Olivier

Original issue reported on code.google.com by olivier....@gmail.com on 30 Jun 2010 at 11:55

Attachments:

• patch.diff

[GoogleCodeExporter]

Very similar in nature to my #51 for commitWithin.

Original comment by liam.obo...@gmail.com on 20 Oct 2010 at 11:37

[GoogleCodeExporter]

The client currently has an optimize parameter which is no longer valid - i 
believe it did exactly what expungeDeletes does (a merging of segments). So 
instead of creating a new parameter in front of timeout which would have broken 
the signature for anyone using timeout, I'm replacing optimize with 
expungeDeletes which i believe to be the proper name for it. 

Original comment by donovan....@gmail.com on 8 Feb 2011 at 7:19

• Changed state: Started

[GoogleCodeExporter]

Committed changes in r58

Original comment by donovan....@gmail.com on 8 Feb 2011 at 7:29

• Changed state: Fixed

[GoogleCodeExporter]

Thanks! ^_^

Original comment by olivier....@gmail.com on 8 Feb 2011 at 7:45