pankajkarman / bias_correction

python library for bias correction
MIT License
30 stars 8 forks source link

not on conda #12

Closed aaronspring closed 2 years ago

aaronspring commented 2 years ago

when I try to create a new climpred release on conda-forge, I get the following error:

conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {'bias-correction'} https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=363119&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d&l=529

so apparently on a linux-64 platform, conda-forge has an issue with bias-correction. Anyone got an idea?

context: https://conda-forge.org/docs/maintainer/adding_pkgs.html#the-recipe-meta-yaml

climpred-feedstock PR: https://github.com/conda-forge/climpred-feedstock/pull/17

aaronspring commented 2 years ago

This is the problem:

Avoid external dependencies

As a general rule: all dependencies have to be packaged by conda-forge as well. This is necessary to assure ABI compatibility for all our packages.

https://conda-forge.org/docs/maintainer/adding_pkgs.html#the-recipe-meta-yaml

aaronspring commented 2 years ago

on the other hand in xskillscore, we use the pypi package properscoring, which is not in conda-forge: https://github.com/conda-forge/xskillscore-feedstock/blob/d5c759a993618d2905a5d108759ad3e93f30e459/recipe/meta.yaml#L29

aaronspring commented 2 years ago

another way would be to put bias_correction on conda-forge

aaronspring commented 2 years ago

Ok. properscoring is on conda, see https://github.com/conda-forge/properscoring-feedstock

following https://stackoverflow.com/questions/64916092/how-do-i-install-pip-packages-through-a-conda-build-recipe, we can use https://docs.conda.io/projects/conda-build/en/latest/resources/commands/conda-skeleton-pypi.html

aaronspring commented 2 years ago

starting https://github.com/conda-forge/staged-recipes/pull/15902