search

pankajkarman / bias_correction

python library for bias correction
MIT License
30 stars 8 forks source link

`bias_correction.XBiasCorrection` does not import after installing via `pip` #6

Closed aaronspring closed 2 years ago

aaronspring commented 2 years ago

Hi @pankajkarman, thanks for this nice code. I especially like the xr.apply_ufunc capabilities.

However, I noticed that XBiasCorrection does not import when installing via pip:

image

I and students from the ASP summer school https://asp.ucar.edu/asp-colloquia want to use your code for bias reduction and to then compute skill with climpred https://github.com/pangeo-data/climpred. Some quantile mapping is required for precip.

(So far I just copied https://github.com/pankajkarman/bias_correction/blob/master/bias_correction.py into climpred in the PR below, but I'd prefer to just add bias-correction to the requirements).

PR how to integrate this into climpred: https://github.com/pangeo-data/climpred/pull/638

pankajkarman commented 2 years ago

Hi @aaronspring, thank you very much for pointing out this issue. You got this issue because the latest version of the repository was not uploaded to pypi. I have updated it there now.