Closed IlyaSemenov closed 7 years ago
@IlyaSemenov did you make it backwards compatible?
Yes, it is backwards compatible. You can pass baseClass
as earlier in the same format. The upstream will print a warning, but it will work fine.
yes, I also checked it.
Thanks for the merge request. 👍
Unfortunately in #3 I didn't pay much attention to the deprecation of
baseClass
in favour ofbaseSelector
in webfonts-generator and almost blindly replaced its usages (and even missed one of them). As the result, the following invalid CSS was generated:This PR fixes the problem, updates tests and documentation. It also adds backward compatibility with old configs that still use
baseClass
.