search

pankajpatel / fontgen-loader

Forked from https://github.com/DragonsInn/fontgen-loader
5 stars 1 forks source link

Already forked #5

Closed jeerbl closed 7 years ago

jeerbl commented 7 years ago

Hello, I already forked this at https://github.com/jeerbl/webfonts-loader, maybe we could unite forces.

Cheers Jerome

pankajpatel commented 7 years ago

That would be great! Where should we move it?

I kept the same name because it will be easy to find who are facing issues while implementing the repo.

pankajpatel commented 7 years ago

I think we should move it under an organization.

Problem is that both of our forks are in use right now. Mine is in less usage.

@IlyaSemenov contributed to it as well.

If we can come up with some good place to move it, it will be good.

I suggest for github.com/dwyl.

jeerbl commented 7 years ago

Yes I know but the loader name had to change on the npm repository. I created webfonts-loader on npm so that people know it is different. I started refactoring the code on my repo and I already included WOFF2 generation support.

Do you want me to add you as a collaborator on my repo? And then we close this one. No need for both of them.

If you don't want to collaborate I can handle it myself, as you wish ;)

jeerbl commented 7 years ago

Ok just saw your second comment, yes indeed we can move it there. I didn't know dwyl but if you think it is a good solution then I'll move it there during the week.

pankajpatel commented 7 years ago

Well @nelsonic from @dwyl can suggest on this.

You can checkout the org repos, I am ok with both options.

pankajpatel commented 7 years ago

@jeerbl can you please check if your version completely shadows ours?

I would suggest that we keep the name same to original one, because we are obviously carrying forward original repo.

We will post a issue in the original repo saying the newest fork and the ways it can be utilized.

jeerbl commented 7 years ago

@pankajpatel I disagree on keeping the same name as I don't want people looking for this repo to see the old one on Google and anywhere else as it is not being updated. I added something in the README for referencing the previous repo.

About the code, I can actually keep it on my Github and add you as collaborator if you are ready to collaborate on further updates.

jeerbl commented 7 years ago

By the way, still about the name, I want the name of the Github repo to be the same as on npm.

pankajpatel commented 7 years ago

@jeerbl alright. your wish. I will redirect all from this repo to yours.

jeerbl commented 7 years ago

I tried this repo and mine seems to completely shadow yours.