search

pankod / react-native-picker-modal-view

An unified React Native Picker Modal component for iOS and Android.
204 stars 56 forks source link

Modal props are not passed through #37

Closed ashish-kale closed 4 years ago

ashish-kale commented 4 years ago

When device orientation is changed on iOS, the modal remains in the old orientation Modal props override can solve the issue using supportedOrientations prop of ModalProps

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.72. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

ashish-kale commented 4 years ago

@kozmonotselcuk @biskuvit Can you please check and merge and release new version for this?

omeraplak commented 4 years ago

Hi @ashish-kale , we’ve launched 1.2.7 version on NPM. Feel free to contact us if you need anything.

ashish-kale commented 4 years ago

@omeraplak I checked the 1.2.7 version, the package has my new source code, but the dist folder has old code. Can you please check?

ashish-kale commented 4 years ago

@omeraplak created #39 to build the included changes.Can you please release this?

omeraplak commented 4 years ago

Hi @ashish-kale , we’ve launched 1.2.8 version on NPM. Feel free to contact us if you need anything.