Make unnecessary arguments optional

pankod / react-native-picker-modal-view

An unified React Native Picker Modal component for iOS and Android.

204 stars 55 forks source link

Make unnecessary arguments optional #67

Open IlyaSemenov opened 3 years ago

IlyaSemenov commented 3 years ago

Please make the following arguments optional:

onClosed
onEndReached

Right now user must pass empty handlers such as onClosed={() => {}}.

issue-label-bot[bot] commented 3 years ago

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.76. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

IlyaSemenov commented 3 years ago

Also, I don't see how items[x].Value is ever used, so it doesn't have to be required, too.