Making it more customizable + fix some inconsequencies at reopening the modal

balazsherczeg commented 3 years ago

Changes:

Make all the elements in the dialog customizable, by adding a styles props, to possibly override default styling.
Make rating component customizable through props or passing the rating component of your own choice. Defaults to AirBnBRating.
When the review is empty, rather then showing an error message, disable Send button. It happens, if there is a style declaration for the disabled state of the button.
Make modal customizable, so you could set animation type by props.
Put a Cancel button for the review view.
Fix modal, that onRequestClose should work.
Make it a fully controlled component to fix some problems when reopening the dialog: 1.) the selected stars are displayed by the props, but the send button behaves by the state, 2.) in some cases the isModalOpen was different in props and state.
Reset the dialog at the reopening (selected stars, view, review, if sent).
Remove deprecated lifecycle methods.

omeraplak commented 3 years ago

@balazsherczeg Hi, Thanks for PR! Could you update README with new props?

balazsherczeg commented 3 years ago

Documentation updated.

omeraplak commented 3 years ago

@balazsherczeg Hi, Could you fix conflicts?

balazsherczeg commented 3 years ago

Hello, I'll take a look at it.

On 20.09.29. 10:16, Ömer Faruk APLAK wrote:

@balazsherczeg https://github.com/balazsherczeg Hi, Could you fix conflicts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pankod/react-native-store-rating/pull/29#issuecomment-700500466, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFL3CN4QHVRW42GJN42DMRLSIGCVNANCNFSM4RZUOH5Q.

omeraplak commented 3 years ago

@balazsherczeg Hi Thank you!

omeraplak commented 3 years ago

@balazsherczeg Hi, Bumped 1.1.0!

balazsherczeg commented 3 years ago

Nice :)

On 20.09.29. 10:31, Ömer Faruk APLAK wrote:

@balazsherczeg https://github.com/balazsherczeg Hi, Bumped 1.1.0!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pankod/react-native-store-rating/pull/29#issuecomment-700507455, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFL3CN4JEE45RSSI6TN7VZTSIGEMDANCNFSM4RZUOH5Q.

pankod / react-native-store-rating

Making it more customizable + fix some inconsequencies at reopening the modal #29