search

panlanfeng / KernelEstimator.jl

The julia package for nonparametric density estimate and regression
Other
26 stars 6 forks source link

Fix Optim API to match v0.5. #4

Closed pkofod closed 8 years ago

pkofod commented 8 years ago

I've changed some things, so the pre v0.5 requirement in METADATA can be removed. Currently, it is not possible to have Optim v0.5 and KernelEstimator v1.7 installed at the same time, so it would be great to merge this asap, and tag a new version of KernelEstimator (0.1.8 I guess).

Thanks!

Edit: Actually, you can wait with tagging a new version until Optim changes the field names as well, but you should be aware, that in the future, the minimum field will be renamed to minimizer, so it's best to use the function based API for getting results in the future.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 60.192% when pulling cf444db1016ce3fae7f93509dcaa4b933875a41c on pkofod:master into 7ba9010ca6afc842f90a30a0193369ce6c21b371 on panlanfeng:master.

panlanfeng commented 8 years ago

Thanks!