search

pannal / Sub-Zero.bundle

Subtitles for Plex, as good you would expect them to be.
Other
1.76k stars 120 forks source link

Improve OpenSubtitles matching #44

Closed pannal closed 8 years ago

pannal commented 9 years ago
pannal commented 8 years ago

don't. use the upcoming release.

pannal commented 8 years ago

I guess we'll have to do this the hard way.

AquaRelliux commented 8 years ago

I still have a problem with 720p subtitles not beeing downloaded for 1080p movies even with the new release. The logs say nothing

chopeta commented 8 years ago

Could you please enable DEBUG in SZ settings and post the logs?

AquaRelliux commented 8 years ago

Yea that is the only thing it says:

2015-11-21 09:13:25,207 (254) : WARNING (logkit:19) - File could not be guessed by subliminal 2015-11-21 09:13:25,207 (254) : CRITICAL (core:574) - Exception in the update function of agent named 'Sub-Zero Subtitles (Movies, 1.3.19.379)', called with guid 'com.plexapp.agents.themoviedb://56292?lang=en' (most recent call last): File "bundles-release/Framework.bundle-dist-ninja/Contents/Resources/Versions/2/Python/Framework/api/agentkit.py", line 1065, in update File "C:\Users\Administrator\AppData\Local\Plex Media Server\Plug-ins\Sub-Zero.bundle\Contents\Codeinit.py", line 233, in update videos, subtitles = getattr(self, "update%s" % self.agent_type)(metadata, media, lang) File "C:\Users\Administrator\AppData\Local\Plex Media Server\Plug-ins\Sub-Zero.bundle\Contents\Codeinit.py", line 253, in update_movies videos = scanMovieMedia(media) File "C:\Users\Administrator\AppData\Local\Plex Media Server\Plug-ins\Sub-Zero.bundle\Contents\Codeinit.py", line 81, in scanMovieMedia scanned_video.id = media.id AttributeError: 'NoneType' object has no attribute 'id'

Very useful

AquaRelliux commented 8 years ago

Here is actual a log over a missmatch

\nas.pilot\public\Media\Movies\Bluray\Ted.2.2015.EXTENDED.720p.BluRay.x264-DRONES\Ted.2.2015.EXTENDED.720p.BluRay.x264-DRONES.mkv 2015-11-21 10:15:41,555 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'year' with confidence 0.72 2015-11-21 10:15:41,556 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'year' with confidence 0.72 2015-11-21 10:15:41,556 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'container' with confidence 1.00 2015-11-21 10:15:41,556 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'container' with confidence 1.00 2015-11-21 10:15:41,556 (540) : DEBUG (logkit:13) - guessit.guess: complex merge, trying our best... 2015-11-21 10:15:41,558 (540) : DEBUG (logkit:13) - guessit.guess: complex merge, trying our best... 2015-11-21 10:15:41,558 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'format' with confidence 0.51 2015-11-21 10:15:41,558 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'format' with confidence 0.51 2015-11-21 10:15:41,558 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'format' with confidence 0.80 2015-11-21 10:15:41,558 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'format' with confidence 0.80 2015-11-21 10:15:41,559 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'releaseGroup' with confidence 0.72 2015-11-21 10:15:41,559 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'releaseGroup' with confidence 0.72 2015-11-21 10:15:41,559 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'videoCodec' with confidence 0.72 2015-11-21 10:15:41,559 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'videoCodec' with confidence 0.72 2015-11-21 10:15:41,559 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'screenSize' with confidence 0.72 2015-11-21 10:15:41,559 (540) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'screenSize' with confidence 0.72 2015-11-21 10:15:41,559 (540) : DEBUG (logkit:13) - guessit.matchtree: Final result: { [0.72] "videoCodec": "h264", [1.00] "container": "mkv", [0.30] "episodeDetails": [ "Pilot" ], [0.80] "format": "BluRay", [0.24] "series": "Ted 2", [0.24] "title": "EXTENDED", [0.72] "releaseGroup": "DRONES", [0.72] "screenSize": "720p", [0.72] "year": 2015, [1.00] "type": "episode" } 2015-11-21 10:15:41,559 (540) : DEBUG (logkit:13) - guessit.matchtree: Final result: { [0.72] "videoCodec": "h264", [1.00] "container": "mkv", [0.30] "episodeDetails": [ "Pilot" ], [0.80] "format": "BluRay", [0.24] "series": "Ted 2", [0.24] "title": "EXTENDED", [0.72] "releaseGroup": "DRONES", [0.72] "screenSize": "720p", [0.72] "year": 2015, [1.00] "type": "episode" }

AquaRelliux commented 8 years ago

Here is one fail of a 1080p movie that has 720p subs that works flawlessly:

-21 10:16:42,697 (d14) : DEBUG (logkit:13) - Scanning video: \nas.pilot\public\Media\Movies\Bluray\Ant-Man.2015.1080p.BluRay.x264-SPARKS\Ant-Man.2015.1080p.BluRay.x264-SPARKS.mkv, subtitles=True, embedded_subtitles=False 2015-11-21 10:16:42,700 (d14) : INFO (logkit:16) - subliminal_patch.patch_video: Scanning video (hints: {'type': 'movie', 'expected_title': ['Ant-Man']}) 'Ant-Man.2015.1080p.BluRay.x264-SPARKS.mkv' in '\nas.pilot\public\Media\Movies\Bluray\Ant-Man.2015.1080p.BluRay.x264-SPARKS' 2015-11-21 10:16:42,700 (d14) : INFO (logkit:16) - subliminal_patch.patch_video: Scanning video (hints: {'type': 'movie', 'expectedtitle': ['Ant-Man']}) 'Ant-Man.2015.1080p.BluRay.x264-SPARKS.mkv' in '\nas.pilot\public\Media\Movies\Bluray\Ant-Man.2015.1080p.BluRay.x264-SPARKS' 2015-11-21 10:16:42,703 (d14) : DEBUG (logkit:13) - guessit.matcher: Property found: type=movie (None) (confidence=1.00) 2015-11-21 10:16:42,703 (d14) : DEBUG (logkit:13) - guessit.matcher: Property found: type=movie (None) (confidence=1.00) 2015-11-21 10:16:42,703 (d14) : DEBUG (logkit:13) - guessit.matcher: Property found: container=mkv (None) (confidence=1.00) 2015-11-21 10:16:42,703 (d14) : DEBUG (logkit:13) - guessit.matcher: Property found: container=mkv (None) (confidence=1.00) 2015-11-21 10:16:42,723 (d14) : DEBUG (logkit:13) - guessit.matcher: Found match tree: 00111111111 222222 33333 444444 555555 6666666666666666666666666666666666666 7777777777777777777777777777777777777 888 000000000 000000 00000 000000 000000 0000000000000000000000000000000000000 0000000000000000000000000000000000000 000 000000 0000000111111111111111111111111111111 0000000111111111111111111111111111111 000 000000000000111111222222222222 000000000000111111222222222222 000000111112 011112222222 000000111112 011112222222 011112 0111111 011112 0111111 \nas.pilot\public\Media\Movies____.._.__.__-___._.____.__.-__._ ffffff ttttttt yyyy sssss ffffff vvvv rrrrrr ttttttt yyyy sssss ffffff vvvv rrrrrr ccc \nas.pilot\public\Media\Movies\Bluray\Ant-Man.2015.1080p.BluRay.x264-SPARKS\Ant-Man.2015.1080p.BluRay.x264-SPARKS.mkv 2015-11-21 10:16:42,723 (d14) : DEBUG (logkit:13) - guessit.matcher: Found match tree: 00111111111 222222 33333 444444 555555 6666666666666666666666666666666666666 7777777777777777777777777777777777777 888 000000000 000000 00000 000000 000000 0000000000000000000000000000000000000 0000000000000000000000000000000000000 000 000000 0000000111111111111111111111111111111 0000000111111111111111111111111111111 000 000000000000111111222222222222 000000000000111111222222222222 000000111112 011112222222 000000111112 011112222222 011112 0111111 011112 0111111 \nas.pilot\public\Media\Movies____.____..__.-____.____..__.-__.___ ffffff ttttttt yyyy sssss ffffff vvvv rrrrrr ttttttt yyyy sssss ffffff vvvv rrrrrr ccc \nas.pilot\public\Media\Movies\Bluray\Ant-Man.2015.1080p.BluRay.x264-SPARKS\Ant-Man.2015.1080p.BluRay.x264-SPARKS.mkv 2015-11-21 10:16:42,723 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'year' with confidence 0.72 2015-11-21 10:16:42,723 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'year' with confidence 0.72 2015-11-21 10:16:42,723 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'title' with confidence 0.72 2015-11-21 10:16:42,723 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'title' with confidence 0.72 2015-11-21 10:16:42,724 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'container' with confidence 1.00 2015-11-21 10:16:42,724 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'container' with confidence 1.00 2015-11-21 10:16:42,724 (d14) : DEBUG (logkit:13) - guessit.guess: complex merge, trying our best... 2015-11-21 10:16:42,724 (d14) : DEBUG (logkit:13) - guessit.guess: complex merge, trying our best... 2015-11-21 10:16:42,724 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'format' with confidence 0.51 2015-11-21 10:16:42,726 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'format' with confidence 0.51 2015-11-21 10:16:42,726 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'format' with confidence 0.80 2015-11-21 10:16:42,726 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'format' with confidence 0.80 2015-11-21 10:16:42,726 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'releaseGroup' with confidence 0.72 2015-11-21 10:16:42,726 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'releaseGroup' with confidence 0.72 2015-11-21 10:16:42,726 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'videoCodec' with confidence 0.72 2015-11-21 10:16:42,726 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'videoCodec' with confidence 0.72 2015-11-21 10:16:42,726 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'screenSize' with confidence 0.72 2015-11-21 10:16:42,726 (d14) : DEBUG (logkit:13) - guessit.guess: Updating matching property 'screenSize' with confidence 0.72 2015-11-21 10:16:42,727 (d14) : DEBUG (logkit:13) - guessit.matchtree: Final result: { [0.72] "videoCodec": "h264", [1.00] "container": "mkv", [0.72] "title": "Ant-Man", [0.80] "format": "BluRay", [0.72] "releaseGroup": "SPARKS", [0.72] "screenSize": "1080p", [0.72] "year": 2015, [1.00] "type": "movie" } 2015-11-21 10:16:42,727 (d14) : DEBUG (logkit:13) - guessit.matchtree: Final result: { [0.72] "videoCodec": "h264", [1.00] "container": "mkv", [0.72] "title": "Ant-Man", [0.80] "format": "BluRay", [0.72] "releaseGroup": "SPARKS", [0.72] "screenSize": "1080p", [0.72] "year": 2015, [1.00] "type": "movie"

AquaRelliux commented 8 years ago

All these subs are on opensubtitles

pannal commented 8 years ago

Those logs show nothing. Please post the whole .log* files on pastebin or dropbox or something so I can investigate.

AquaRelliux commented 8 years ago

Here you go

https://onedrive.live.com/prev?cid=dbd820af80263892&id=DBD820AF80263892%216286&v=TextFileEditor

pannal commented 8 years ago

Please try the bleeding edge: https://github.com/pannal/Sub-Zero.bundle/archive/master.zip And report back with full logs, again, please. Thanks :)

AquaRelliux commented 8 years ago

I am sorry to sat pannal but it seems that the update you sent did no difference? :)

https://onedrive.live.com/prev?cid=dbd820af80263892&id=DBD820AF80263892%216287&v=TextFileEditor

I really appreciate your effort though

pannal commented 8 years ago

Please do the same thing again, with the bleeding edge. Trying to pinpoint your issue.

Do you have another method of contacting you more on-time? Skype? XMPP/Jabber?

AquaRelliux commented 8 years ago

Is that link really downloading the latest version? Because it has the same version number

pannal commented 8 years ago

Yeah it is. I'm trying to pinpoint your issue. Please make sure you delete the old version, extract the new one, and restart your PMS.

AquaRelliux commented 8 years ago

ok will do right away!

AquaRelliux commented 8 years ago

Still no cookie I am afraid:

https://onedrive.live.com/prev?cid=dbd820af80263892&id=DBD820AF80263892%216288&v=TextFileEditor

AquaRelliux commented 8 years ago

Hard tell tell for me touugh because I don't understand what is going wrong xD

pannal commented 8 years ago

I've got enough info. Debugging.

AquaRelliux commented 8 years ago

ok :)

pannal commented 8 years ago

Please try again. Still, do you have another option of contacting you, like Skype or Jabber?

AquaRelliux commented 8 years ago

I have Skype is there a way to send a private message here?

AquaRelliux commented 8 years ago

IT SOLVED THE ISSUE! :dancer:

AquaRelliux commented 8 years ago

Both english and swedish subs downloaded now perfectly

AquaRelliux commented 8 years ago

New debug log if you want to see how it works now:

https://onedrive.live.com/prev?cid=dbd820af80263892&id=DBD820AF80263892%216289&v=TextFileEditor

pannal commented 8 years ago

Perfect! Thanks for helping!

AquaRelliux commented 8 years ago

Just wow that really solved all the problems on my movie library. It downloaded swedish subs for pretty much every movie now and added english on the ones that missed it! Sending you a beer for the trouble! have a good night! Well here in Sweden it is late now so I am gonna sleep but I have no idea what time zone your in :P

pannal commented 8 years ago

We're in the same timezone, mate :)

That's the weekend-burden of free-time projects. I'm drafting a release based on your findings.