search

pannal / Sub-Zero.bundle

Subtitles for Plex, as good you would expect them to be.
Other
1.76k stars 120 forks source link

Plugins Translation into French #486

Open FayzB opened 6 years ago

FayzB commented 6 years ago

Possible to translate the Plugins in French I can take care of it I only need the file to translate

pannal commented 6 years ago

Yep, this'll come once Plex Inc fixes their web client to send the X-Plex-Language header. Then we can properly translate the app.

458

FayzB commented 6 years ago

Currently I started the translation by modifying the .json manually to have it on my personal PMS GitHub link https://github.com/FayzB/Traduction-Plugins-PMS

pannal commented 6 years ago

Well that's great. Keep doing that and we'll merge your progress once Plex Inc has fixed the issue.

FayzB commented 6 years ago

OK thanks a lot with your plugins which helps us a lot

morpheus133 commented 6 years ago

Hi @FayzB! Your methode is not the best for translation. You only need to add Contents/Strings/fr.json

Check: https://github.com/pannal/Sub-Zero.bundle/issues/458

And also need to add all the translatable strings between L() method.

pannal commented 6 years ago

@morpheus133 that's being worked on by @ukdtom. We're still deciding on a viable translation method.

pannal commented 6 years ago

We will be using POEditor.com for SZ's translation. Join here: http://v.ht/szi18n

FayzB commented 6 years ago

@morpheus133 yes not wrong But it allows to have the plugins in French while Plex Inc corrects the bug. After I would correct the file

pannal commented 6 years ago

@FayzB I have a feeling the bugfix is around the corner.

FayzB commented 6 years ago

Hi @pannal translation JPG https://github.com/FayzB/Traduction-Plugins-PMS/tree/master/Sub-Zero.bundle/Contents/Resources

pannal commented 6 years ago

Oof, I'm not sure I want to include separate images for all languages to be honest. That'd increase the package size by at least 7 MB for 10 languages (and we're at 13).

pannal commented 6 years ago

@FayzB any news on the French translation? I've seen you join on POEditor