search

pannal / Sub-Zero.bundle

Subtitles for Plex, as good you would expect them to be.
Other
1.76k stars 120 forks source link

Delete internal subtitles after extracting them. #559

Open Maximus97 opened 6 years ago

Maximus97 commented 6 years ago

I think this is a good enhancement because right now, you get two identical subtitle files. Two identical subtitles is a problem if the original had hearing impaired tags, because then you have two different subtitles and you can't differentiate between them in many clients.

ukdtom commented 6 years ago

That's a very scary terrible idea, IMHO

IMHO dangerous to mess with peoples medias, since what if something goes wrong during the remux of the media?

And at last, AFAIK, all players shows (External) after a sub, of external

fkick commented 6 years ago

Agreed, internal embed subtitles should not be automatically deleted. Let’s not mess with the media files themselves please and thank you.

On Aug 31, 2018, at 1:50 PM, Tommy Mikkelsen notifications@github.com wrote:

That's a very scary terrible idea, IMHO

IMHO dangerous to mess with peoples medias, since what if something goes wrong during the remux of the media?

And at last, AFAIK, all players shows (External) after a sub, of external

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pannal/Sub-Zero.bundle/issues/559#issuecomment-417758081, or mute the thread https://github.com/notifications/unsubscribe-auth/AH1_m5CqsSZiWkZ9PrF_PrrxatULCs_Xks5uWYVrgaJpZM4WVhtD .

pannal commented 6 years ago

Well, who said this should be a feature that's on by default? It's definitely doable and not very complex.

But!

because then you have two different subtitles and you can't differentiate between them in many clients.

Which clients do that? Most of them differentiate exactly between embedded and external (for example SRT internal and SRT)

Maximus97 commented 6 years ago

Which clients do that? Most of them differentiate exactly between embedded and external (for example SRT internal and SRT)

I was wrong about that.

Anyways, I extract my subtitles because I want to remove HI tags (which I think is the case for many, correct me if I am wrong), and then the embedded ones become misleading and useless.