search

pannal / Sub-Zero.bundle

Subtitles for Plex, as good you would expect them to be.
Other
1.76k stars 120 forks source link

Series upgrade: SZ did not extract the embedded SRT subtitles (2) #692

Open cphmichael opened 5 years ago

cphmichael commented 5 years ago

I have attached data from the latest 4 series that are updated:

In Kitana 'History' they are all shown with there first upload date. Not the update date.

If you look at Emergence S01E05 - it says:

If I click on the Emergence S01E05 - Kitana says 'No current subtitle in storage'.

It is the same pattern for the other updated series.

SZ.zip

Sonarr - Emergence S01E05

Sonarr - Treadstone S01E03

Sonarr - Prodigal Son S01E06

Sonarr - Batwoman S01E04

PMS - Emergence S01E05

PMS - Treadstone S01E03

PMS - Prodigal Son S01E06

PMS - Batwoman S01E04

Kitana - Emergence S01E05 (1)

Kitana - Emergence S01E05 (2)

Kitana - Treadstone S01E03 (1)

Kitana - Prodigal Son S01E06 (1)

Kitana - Batwoman S01E04 (1)

pannal commented 5 years ago

In Kitana 'History' they are all shown with there first upload date. Not the update date. If you look at Emergence S01E05 - it says:

auto, English in TV Shows (embedded, score: 0), 2019-10-30 19:03 If I click on the Emergence S01E05 - Kitana says 'No current subtitle in storage'.

Yes, those are historic entries. The part ID changes once the physical media is upgraded, so on the next cleanup run SZ detects that the stored info for the part ID that was used before is non existant and cleans the storage. This happens regularly.

That doesn't kill the historic entries, though.

If the issue persists and upgrades aren't properly detected, I might add several other "embedded extraction points" in the cleanup and scheduler phase.

pannal commented 5 years ago

Subtitle storage maintenance runs every 7 days, FindBetter runs periodic, as defined by the user, SearchAllRecentlyAddedMissing as well.

I think this might be the only choice for us here, as the bug reports that I've posted in the internal Plex bug tracker regarding upgrades and calling of agents have been widely ignored.

pannal commented 5 years ago

If you have the same settings set as in #691, essentially ignoring the whole SZ process once you have one matching embedded subtitle in a media file, this will not do anything.

cphmichael commented 5 years ago

I have not changed anything i the settings.

I believe that the embedded subtitles are a better match than an external downloaded subtitles.

Therefore I prefer to extract the embedded subtitles with configured default mods over downloading an external subtitles.

If SZ is not able to detect when an item is upgraded and therefore not extracting the embedded subtitles, my thought was that the scheduler could do the job :-)

pannal commented 4 years ago

my thought was that the scheduler could do the job :-)

Yes, it does now.

SZ can only react to what the PMS is doing. If the agent isn't called upon an upgrade, SZ doesn't know that anything's changed.