search

pannal / Sub-Zero.bundle

Subtitles for Plex, as good you would expect them to be.
Other
1.76k stars 120 forks source link

issue using unmodified advanced_settings.json #724

Open amrisel opened 4 years ago

amrisel commented 4 years ago

When I try to enable advanced_settings.json by placing it in the Data directory the plugin does not work. It dissapears from Kitana and clicking the config icon for the agent does not cause the options window to open.

Moving the file to another folder fixes the issue. The file has not been modified in any way other than rchanging the file extension.

pannal commented 4 years ago

Do you have logs?

amrisel commented 4 years ago

I saw in the log that the error said no json object. I deleted the initial comment in the template file, and all other comments in the file so it conforms to json, and now it works.

Not sure if that was an instruction I missed, or if the script is supposed to filter out the comments.

Thanks for a great addon, and taking the time to respond btw :)

pannal commented 4 years ago

The implementation should ignore comments, yes. That's weird. What's your setup like?

ghost commented 3 years ago

I saw in the log that the error said no json object. I deleted the initial comment in the template file, and all other comments in the file so it conforms to json, and now it works.

Not sure if that was an instruction I missed, or if the script is supposed to filter out the comments.

Thanks for a great addon, and taking the time to respond btw :)

i ran into the same issue, could you please specify what you deleted to make it work ? or can you copy the final edit ? thanks in advance

pannal commented 3 years ago

OK still super weird as the implementation SZ uses can work with comments and stuff.