search

pannal / plex-for-kodi

Unoffical Plex for Kodi add-on releases.
GNU General Public License v2.0
266 stars 32 forks source link

Add settings option to stops post-play timer with ok button #57

Closed bowlingbeeg closed 11 months ago

bowlingbeeg commented 11 months ago

Most post-play timer count down screens allow you to just click ok/select to go to the next video so it seems like that should be the default. This gives the user a setting to change that behavior so that it cancels the timer when clicking the ok/select.

pannal commented 11 months ago

Interestingly this has already been added in the last release, but thank you anyways :)

Not with a toggle, but as default behaviour (as I figured this makes a lot more sense).

bowlingbeeg commented 11 months ago

No, you misunderstand. I don't think the default should be to dismiss the timer. No other streaming service does it that way. That's why I added the toggle and made the default behave like all other services where the ok button plays the next video

pannal commented 11 months ago

Yes I know, the setting will be added in the next release. I just closed your PR as I'd already implemented that :)

pannal commented 11 months ago

BTW I don't think the default should be to dismiss the timer. - I think there's an argument to be made here. We're showing a PAUSE button that's selected by default. Of course the expected default action would be to cancel the timer, which is why I'm thinking about leaving the default on - regardless of what anyone else does.

If it was a play button, I'd completely agree.