pannal / plex-for-kodi

Unoffical Plex for Kodi add-on releases.
GNU General Public License v2.0
237 stars 30 forks source link

Updates to reposition and align ratings on the pre-play screen #71

Closed rdswords closed 6 months ago

rdswords commented 7 months ago

GHI (If applicable): #69

Description: Adjustments and minor cleanup to reposition the internet ratings images/text up to the same line as the title, with some pixel value recalcs to ensure everything is again aligned in conjunction with the previous font definition fix.

Checklist:

rdswords commented 6 months ago

@pannal Just a reminder that this request is still open and should still be valid against all recent comments

pannal commented 6 months ago

Thanks!

pannal commented 6 months ago

Wait. Why doesn't that look right? image

pannal commented 6 months ago

Reverting your change yields: image

(which is arguably better I think)

pannal commented 6 months ago

This is with posy 2 on the group list and posy 2 on both images: image

pannal commented 6 months ago

posy 4 on the grouplist and posy 2 on the images: image

Which imho is perfect.

rdswords commented 6 months ago

Did you get the height change of the group from 32 to 60 that those values should align to?

pannal commented 6 months ago

Yeah I've seen that, it's the first screenshot

pannal commented 6 months ago

I'll stick with my last configuration for 0.7.1, if you want to change it, we can, but that's not going to make it for 0.7.1 as I'm preparing its release now

pannal commented 6 months ago

Sorry, I should've checked on the PR branch before merging this

rdswords commented 6 months ago

With the height of the group lists matched at 60 for the title text and the review elements, and the height of each element in the review group matched at 30, the posy of 15 for the elements in the review group should have them placed to align with the vertical center of the 60 height elements. It all aligns on my end unless some value is being missed by one of us.

Screenshot_20231216-162456