pannal / plex-for-kodi

Unoffical Plex for Kodi add-on releases.
GNU General Public License v2.0
266 stars 32 forks source link

[Feature Request] Show subtitles title if available #72

Closed Generator closed 9 months ago

Generator commented 9 months ago

Description:

Subtitles selection only show language, multiple subtitles with same language there's no way to distinguish from each other.

Addon subtitles selection:

Screenshot_20231209-203047 Screenshot_20231209-203103 Screenshot_20231209-203118

Kore subtitles selection:

Screenshot_20231208-161231_crDroid Home Screenshot_20231208-161238_crDroid Home

Details:

Checklist

pannal commented 9 months ago

We already honor and show the SDH/HI and the Forced flag. If it's not set, I can't do anything about it. Showing the title could work in these cases, I'll see what I can do for 0.7.1.

Generator commented 9 months ago

Yes, but there's no distinguish from example European Portuguese and Brazilian Portuguese, both only show Portuguese, the same happens to others languages like French, Spanish, Chinese...

pannal commented 9 months ago

Oh, pt-BR, zh-hans etc. isn't handled properly? That's actually bad. Especially considering I've built Sub-Zero and provided the core for Bazarr :D

I'll look into it!

pannal commented 9 months ago

@Generator please try 0.7.1-beta1: script.plexmod.zip

It should fix all of your issues.

Generator commented 9 months ago

Now it show subtitle titles, also fixes Chinese missing characters Screenshot_20231210-120052 Screenshot_20231210-120106

looks fixed to me

PS: It also shows subtitles names localized, another improvement

Generator commented 9 months ago

Fixed in v0.7.1