Fix button size issue when multiple media versions exist

pannal / plex-for-kodi

Unoffical Plex for Kodi add-on releases.

GNU General Public License v2.0

237 stars 30 forks source link

Fix button size issue when multiple media versions exist #79

Closed bowlingbeeg closed 6 months ago

bowlingbeeg commented 6 months ago

The function that is getting called to resize the buttons is called for every episode in the season so the button sizes keep getting reset as each episode loads. This fix will only calculate the size for the episode that is selected. It also will re-calculate the button size every time a new episode is selected.

GHI (If applicable): #

Description:

Checklist:

[X] I have based this PR against the develop branch

bowlingbeeg commented 6 months ago

ok, uploaded a new version with the hardcoded xml changes for the button sizes. Let me know if you like this better.

pannal commented 6 months ago

Hmm, I'm not sure duplicating IDs is a good idea. I don't know how the Kodi XML engine handles this, but I'd avoid it. Maybe it's time we look into this, which should also help us with copy&paste code in general.

Edit: Look at this as well.

pannal commented 6 months ago

Do you want me to merge this and test the includes myself or do you want to take a look?

pannal commented 6 months ago

Damn, includes don't seem to work with addons.

bowlingbeeg commented 6 months ago

Yeah, was going to say that I tried the includes stuff and couldn't get it to work. I tried searching online for other ways to do it but couldn't really find anything that worked.

pannal commented 6 months ago

OK, found a clean solution that doesn't involve duplicate control IDs. It's a little complicated but seems stable, will push later today. Based on this PR.