search

pannal / plex-for-kodi

Unoffical Plex for Kodi add-on releases.
GNU General Public License v2.0
237 stars 30 forks source link

updated strings.po Spanish. #88

Closed Deci8BelioS closed 5 months ago

Deci8BelioS commented 5 months ago

GHI (If applicable): #

Description:

Checklist:

pannal commented 5 months ago

Thank you, I'll only merge the updated strings. I'll adjust addon.xml for the release versions to reuselanguageinvoker and I won't merge the changed icon.

Please drop the other commits apart from the PO changes.

Deci8BelioS commented 5 months ago

Thank you, I'll only merge the updated strings. I'll adjust addon.xml for the release versions to reuselanguageinvoker and I won't merge the changed icon.

Please drop the other commits apart from the PO changes.

I have already reverted the addon icon, should I leave the addon.xml file as the original one?

pannal commented 5 months ago

Yes, please. I'm adding reuselanguageinvoker by default and have developed a setting to toggle this feature.

Deci8BelioS commented 5 months ago

Yes, please. I'm adding reuselanguageinvoker by default and have developed a setting to toggle this feature.

I just changed the file

pannal commented 5 months ago

Hmm. Why would you think reuselanguageinvoker would make any difference for this addon? It's long running, so the invoker would not have to be reused anyways, as long as one doesn't re-open the addon multiple times.

Deci8BelioS commented 5 months ago

Hmm. Why would you think reuselanguageinvoker would make any difference for this addon? It's long running, so the invoker would not have to be reused anyways, as long as one doesn't re-open the addon multiple times.

I honestly don't know exactly what it does, I thought it was to get the language you have set in kodi.

pannal commented 5 months ago

No, that's about the Python language invoker, not languages. Those work just by existing AFAIK.