search

panodata / dwdweather2

Python client to access weather data from Deutscher Wetterdienst (DWD), the federal meteorological service in Germany.
https://community.panodata.org/t/dwdweather2-a-python-client-to-access-weather-data-from-deutscher-wetterdienst-dwd/98
MIT License
72 stars 13 forks source link

Add `10_minutes` resolution of `solar` category #23

Closed arneki closed 4 years ago

arneki commented 4 years ago

Adds 10 minutes resolution of solar data.

amotl commented 4 years ago

Dear @arneki,

thanks a bunch for your contribution! Just a minor thing: Within the "hourly" category, we designated solar_duration to be an int [1]. Can you verify that with the data coming from the "10_minutes" category?

With kind regards, Andreas.

[1] https://github.com/panodata/dwdweather2/blob/02d871ea4b67f4aa5c0236e6597da47f8c41f6a6/dwdweather/knowledge.py#L444-L445

arneki commented 4 years ago

Hi Andreas! In the data the solar duration is a floating point number and has a maximum of 0.167h (= 10 minutes), so int does not fit here.

amotl commented 4 years ago

int does not fit here.

Thanks!

I've merge your commit and made a new release through dwdweather2==0.12.0. Thanks again and enjoy!