panodata / dwdweather2

Python client to access weather data from Deutscher Wetterdienst (DWD), the federal meteorological service in Germany.
https://community.panodata.org/t/dwdweather2-a-python-client-to-access-weather-data-from-deutscher-wetterdienst-dwd/98
MIT License
72 stars 13 forks source link

Requests restricted #29

Closed bmxp closed 4 years ago

bmxp commented 4 years ago

When installing dwdweather2 I find dwdweather2 0.14.0 has requirement requests<2.23,>=2.22

Is there a reason why requests 2.24.0 is banned?

amotl commented 4 years ago

Dear @bmxp,

I believe there is no particular reason to pin this to a specific version of the requests library. Please let me know if I should cut a new release relaxing the version pinning on this dependency.

However, I strongly recommend to move on to the Wetterdienst package. It is the successor library to dwdweather and dwdweather2 and is becoming more and more popular these days. We have been trying to get this en par with all the features offered by dwdweather2 and we have come pretty far these days. Enjoy!

With kind regards, Andreas.

cc @gutzbenj

bmxp commented 4 years ago

Thank you for your hint about Wetterdienst. It might be indeed the way to go. If you feel that dwdweather2 is a kind of deprecated then there is no need for a change, otherwise a version with a more relaxed dependency on requests would be good, just to prevent incompatabilities when using this lib with other projects.

Thanks for your feedback, kind regards, Bernd