panoply / vscode-liquid

💧Liquid language support for VS Code
https://marketplace.visualstudio.com/items?itemName=sissel.shopify-liquid
Other
171 stars 22 forks source link

comments_enabled? not supporting format / syntax highlighting #125

Closed outerpreneur closed 1 year ago

outerpreneur commented 1 year ago

``Screen Shot 2022-11-03 at 12 23 03 PM

When I type comments_enabled, the formatter doesn't support my code anymore

` {% if blog.comments_enabled? %}

{% if article.comments_count > 0 } {% else %} There are no comments in this article {% endif %}

{% endif %}`

panoply commented 1 year ago

Good find!

Will apply patch.

artfusion commented 1 year ago

Hi Agreed yes this has also been my experience. It is being talked about on the udemy course

image
panoply commented 1 year ago

Shipping in 3.1.2 (this week)

panoply commented 1 year ago

Sorry for the delay here, a lot more went into this version. Instead of pushing a patch this will be fixed in the next minor 3.2.0 - awaiting some final tests. I'll close this as 76db954 solved it anyway.

panoply commented 1 year ago

Re-opening this one as per #137 the issue still persists but in different structures.

syf107 commented 1 year ago

Hello, I found this and still have a problem with the comment. It's still read as reserve word of comment tag and commenting to the bottom of the code. I'm on the latest version of this extension 3.2.2 on vscode. image

panoply commented 1 year ago

Shipping in #138 – Available tomorrow.