panoply / vscode-liquid

💧Liquid language support for VS Code
https://marketplace.visualstudio.com/items?itemName=sissel.shopify-liquid
Other
173 stars 22 forks source link

Toggle line comment doesn't work #139

Closed SHiLLySiT closed 1 year ago

SHiLLySiT commented 1 year ago

I'm not sure if this is a bug, or a configuration issue on my end, but I can't seem to figure out how to get the Toggle line comment shortcut working in Liquid files. Using the shortcut key or command does nothing. However switching the language mode to HTML causes Toggle line comment command to work again, but then the syntax highlighting is wrong and I lose Liquid intellisense.

panoply commented 1 year ago

Hey @SHiLLySiT

Interesting, can you give me some more information? What is the command sequence you use?

SHiLLySiT commented 1 year ago

@panoply Do you mean the keyboard shortcut? I have it mapped to CTRL+/ which I think might be the default.

For what its worth, i see this behavior when using the keyboard shortcut or executing the command from the vscode command palette.

panoply commented 1 year ago

Yeah, this should be working. I am on a Mac though. I'll do some investigating. @toklok can you try this on your machine?

toklok commented 1 year ago

Yeah, this should be working. I am on a Mac though. I'll do some investigating. @toklok can you try this on your machine?

I'm seeing the same thing, I do remember it working though, i'm unable to select my liquid code and Cmd / to comment some code

{% if true %} {% endif %} if I do Cmd / I would expect the outcome to be {%- comment -%}{% if true %} {% endif %}{%- endcomment -%}

brettwbyron commented 1 year ago

I'm also having the same issue. My Cmd + / nor command pallet do anything. Any updates on this?

EDIT: I am, however, able to type "comment" + tab and that spits out a comment. But, I still can't highlight and block/line comment

anantakrishna commented 1 year ago

Let me add that it's not only about commenting Liquid code, but plain HTML in the liquid files, too. My use case is to add a documenting comment above an element. I usually add an empty line and hit Ctrl+/ to make it a comment (i.e. <!-- -->) and type some text there.

elburro1887 commented 1 year ago

I am having the same issue, when trying to comment via CMD + / on Mac. Works neither in JS or HTML parts of the file.

panoply commented 1 year ago

🚢