search

panoply / vscode-liquid

💧Liquid language support for VS Code
https://marketplace.visualstudio.com/items?itemName=sissel.shopify-liquid
Other
171 stars 23 forks source link

Will IntelliSense for styles be supported? #156

Open patrulea opened 1 year ago

patrulea commented 1 year ago

Syntax highlighting works as expected in suffixed stylesheets and within {% stylesheet %}/<style> regions, but will IntelliSense and validation come to future releases or Liquify?

I saw it working in one comment from @panoply in 2021: https://github.com/panoply/vscode-liquid/issues/56#issuecomment-885053218

I’m on 4.0 RC.

panoply commented 1 year ago

Hey @patrulea

Awesome to see you on 4.0 RC already. I can make it available in the official, was going to hold off until Liquify but if there is a need for it, I am happy to implement. Would need feedback on it,

panoply commented 1 year ago

@patrulea I'll try get this out over weekend. Would you be able to test?

patrulea commented 1 year ago

I’m ready 🫡

panoply commented 1 year ago

I'll ping you when the v4 VSIX in next branch is ready and you can just reinstall. Things should work as expected. It's a good idea to periodically check the commits in #138 because I am publishing all the final refinements and ironing out any issues occuring.

Feedback is always appreciated too in the current RC and any bugs/errors you might be encountering is a huge help given you are already leveraging the latest (only a few users are as bleeding edge as us) ;)

patrulea commented 1 year ago

IntelliSense and syntax highlighting for CSS and JavaScript work just fine within <style> and <script> tags but validation is totally absent.

Though, writing @define-mixins (custom syntax provided by post-css-mixins) breaks IntelliSense and syntax highlighting for the rest of the Liquid code in the file. I use an extension for the PostCSS language and recognize and validate this syntax in dedicated .css and .pcss files.