[4.0] HTML attribute line dedenting after typing "end"

panoply / vscode-liquid

💧Liquid language support for VS Code

https://marketplace.visualstudio.com/items?itemName=sissel.shopify-liquid

Other

173 stars 22 forks source link

[4.0] HTML attribute line dedenting after typing "end" #160

Open davidwarrington opened 1 year ago

davidwarrington commented 1 year ago

For reference I'm using the latest VSIX on the next branch

This is a weird one. I was just editing an inline attribute that contains liquid and found that if I type anything after "end" inside the closing Liquid tag it dedents the line.

https://github.com/panoply/vscode-liquid/assets/9138568/cfd567eb-70ff-451f-bf57-cbf13716f976

This isn't a critical issue - I can reindent it.

panoply commented 1 year ago

Interesting one. Definitely a bug, probably because in Æsthetic it is looking for {% endif %} but it shouldn't, so we have a defect here. I'll upstream to Æsthetic. Might be something I introduced with markup rules lineBreakValue and delimiterTerminus which I still haven't bumped in latest version.

In any sense (as always) this was a good catch.