panoptes / POCS

An Observatory Control System for the PANOPTES citizen-science project designed to help find transiting exoplanets! :telescope: :stars:
https://pocs.readthedocs.io/en/latest/
MIT License
80 stars 49 forks source link

Use `self._driver` in `SDKCamera` instances #1140

Closed danjampro closed 3 years ago

danjampro commented 3 years ago

SDK camera subclasses are currently very hard / impossible to override cleanly because of problems with the driver. This is because Camera (the class name) is directly referenced in instance methods, which should be using self instead.

Types of changes

codecov[bot] commented 3 years ago

Codecov Report

Merging #1140 (33a02d4) into develop (713e08d) will increase coverage by 0.18%. The diff coverage is 59.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1140      +/-   ##
===========================================
+ Coverage    83.22%   83.40%   +0.18%     
===========================================
  Files           82       86       +4     
  Lines         7040     7358     +318     
  Branches       608      627      +19     
===========================================
+ Hits          5859     6137     +278     
- Misses        1011     1048      +37     
- Partials       170      173       +3     
Impacted Files Coverage Δ
src/panoptes/pocs/camera/gphoto/base.py 100.00% <ø> (ø)
src/panoptes/pocs/sensor/remote.py 85.00% <ø> (ø)
src/panoptes/pocs/utils/logger.py 100.00% <ø> (ø)
tests/scheduler/test_base_scheduler.py 100.00% <ø> (ø)
tests/scheduler/test_dispatch_scheduler.py 94.11% <ø> (ø)
src/panoptes/pocs/mount/ioptron/ieq30pro.py 19.49% <5.88%> (+0.68%) :arrow_up:
src/panoptes/pocs/focuser/astromechanics.py 32.14% <25.00%> (+5.02%) :arrow_up:
src/panoptes/pocs/focuser/serial.py 46.93% <30.76%> (+23.12%) :arrow_up:
src/panoptes/pocs/sensor/power.py 41.97% <39.53%> (ø)
src/panoptes/pocs/mount/ioptron/cem40.py 40.34% <44.24%> (+13.14%) :arrow_up:
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce113df...33a02d4. Read the comment docs.