panoptes / POCS

An Observatory Control System for the PANOPTES citizen-science project designed to help find transiting exoplanets! :telescope: :stars:
https://pocs.readthedocs.io/en/latest/
MIT License
80 stars 49 forks source link

Typo in AbstractCamera class #1155

Closed fergusL closed 3 years ago

fergusL commented 3 years ago

Describe the bug Noticed a small typo in the panoptes.pocs.camera.AbstractCamera class in the take_exposure() method, missing an extra * when passing kwargs into to the call to _start_exposure() . This was causing a unit test failure in Huntsman-Pocs (tests/test_camera.py::test_observation), E 11-19 02:55:07.369 PanError: Error starting exposure on dslr.00 (SC7497) port=/dev/fake/dslr.focuser.00 with focuser& filterwheel: TypeError("_start_exposure() got multiple values for argument 'seconds'")

To Reproduce https://github.com/panoptes/POCS/blob/5c53341b496f98ca01fcde6d1163a92b8be41de4/src/panoptes/pocs/camera/camera.py#L522

Expected behavior NA

Related Issues NA