search

panoptes / POCS

An Observatory Control System for the PANOPTES citizen-science project designed to help find transiting exoplanets! :telescope: :stars:
https://pocs.readthedocs.io/en/latest/
MIT License
78 stars 49 forks source link

Remove unused dependency: click #1193

Closed gdrosos closed 1 year ago

gdrosos commented 1 year ago

Summary

Hello @wtgee,

I hope you're doing well! I've just opened this pull request that proposes the removal of the unused click dependency from the setup.cfg configuration file. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects. Your insights on this would be really valuable.

Rationale

The click package was added in 3247290bc, but upon analysis of the codebase, it was found that it is not currently being utilized within the project. Removing this unused dependency can reduce the overall footprint of the application, mitigate potential security risks, and simplify the dependency management process.

Changes

Impact

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 55.07% and project coverage change: -8.08% :warning:

Comparison is base (4908119) 83.08% compared to head (bf1fa76) 75.00%. Report is 141 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1193 +/- ## =========================================== - Coverage 83.08% 75.00% -8.08% =========================================== Files 86 93 +7 Lines 7425 7890 +465 Branches 635 1105 +470 =========================================== - Hits 6169 5918 -251 - Misses 1083 1826 +743 + Partials 173 146 -27 ``` | [Files Changed](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes) | Coverage Δ | | |---|---|---| | [src/panoptes/pocs/camera/gphoto/remote.py](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes#diff-c3JjL3Bhbm9wdGVzL3BvY3MvY2FtZXJhL2dwaG90by9yZW1vdGUucHk=) | `0.00% <0.00%> (-21.57%)` | :arrow_down: | | [src/panoptes/pocs/mount/ioptron/ieq30pro.py](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes#diff-c3JjL3Bhbm9wdGVzL3BvY3MvbW91bnQvaW9wdHJvbi9pZXEzMHByby5weQ==) | `0.00% <0.00%> (-19.50%)` | :arrow_down: | | [src/panoptes/pocs/sensor/power.py](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes#diff-c3JjL3Bhbm9wdGVzL3BvY3Mvc2Vuc29yL3Bvd2VyLnB5) | `40.23% <0.00%> (-1.74%)` | :arrow_down: | | [...rc/panoptes/pocs/state/states/default/analyzing.py](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes#diff-c3JjL3Bhbm9wdGVzL3BvY3Mvc3RhdGUvc3RhdGVzL2RlZmF1bHQvYW5hbHl6aW5nLnB5) | `5.55% <0.00%> (-54.45%)` | :arrow_down: | | [...rc/panoptes/pocs/state/states/default/observing.py](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes#diff-c3JjL3Bhbm9wdGVzL3BvY3Mvc3RhdGUvc3RhdGVzL2RlZmF1bHQvb2JzZXJ2aW5nLnB5) | `13.33% <0.00%> (-62.86%)` | :arrow_down: | | [src/panoptes/pocs/state/states/default/tracking.py](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes#diff-c3JjL3Bhbm9wdGVzL3BvY3Mvc3RhdGUvc3RhdGVzL2RlZmF1bHQvdHJhY2tpbmcucHk=) | `6.66% <0.00%> (-76.67%)` | :arrow_down: | | [src/panoptes/pocs/utils/cli/main.py](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes#diff-c3JjL3Bhbm9wdGVzL3BvY3MvdXRpbHMvY2xpL21haW4ucHk=) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [src/panoptes/pocs/utils/database.py](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes#diff-c3JjL3Bhbm9wdGVzL3BvY3MvdXRpbHMvZGF0YWJhc2UucHk=) | `0.00% <0.00%> (ø)` | | | [src/panoptes/pocs/utils/logger.py](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes#diff-c3JjL3Bhbm9wdGVzL3BvY3MvdXRpbHMvbG9nZ2VyLnB5) | `86.84% <ø> (-13.16%)` | :arrow_down: | | [tests/test\_ioptron.py](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes#diff-dGVzdHMvdGVzdF9pb3B0cm9uLnB5) | `66.66% <0.00%> (+0.70%)` | :arrow_up: | | ... and [48 more](https://app.codecov.io/gh/panoptes/POCS/pull/1193?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes) | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/panoptes/POCS/pull/1193/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=panoptes)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdrosos commented 1 year ago

LGTM, thanks for catching this @gdrosos!

You are welcome @wtgee! Do you also believe it is safe to remove urllib3, since it is also not directly used in the code? Or there is a reason for pinning its version? https://github.com/panoptes/POCS/blob/34b74ef11a65233b7317d78bbc25f4624fb31f6e/setup.cfg#L52