search

panoptes / POCS

An Observatory Control System for the PANOPTES citizen-science project designed to help find transiting exoplanets! :telescope: :stars:
https://pocs.readthedocs.io/en/latest/
MIT License
77 stars 49 forks source link

Fix weather station autodetect #1254

Closed wtgee closed 2 months ago

wtgee commented 2 months ago

When the weather sensor was introduced it used the term port instead of the serial_port that was found in the config. This led to some inconsistencies and bugs, so this PR cleans those up.

Tested on PAN026

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 70.21%. Comparing base (6bdacc8) to head (3c04b16).

:exclamation: Current head 3c04b16 differs from pull request most recent head 2ee1ffa. Consider uploading reports for the commit 2ee1ffa to get more accurate results

Files Patch % Lines
src/panoptes/pocs/sensor/weather.py 0.00% 3 Missing :warning:
src/panoptes/pocs/utils/service/weather.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1254 +/- ## =========================================== - Coverage 70.22% 70.21% -0.02% =========================================== Files 100 100 Lines 8399 8399 Branches 1164 1164 =========================================== - Hits 5898 5897 -1 Misses 2352 2352 - Partials 149 150 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.