search

panoptes / POCS

An Observatory Control System for the PANOPTES citizen-science project designed to help find transiting exoplanets! :telescope: :stars:
https://pocs.readthedocs.io/en/latest/
MIT License
77 stars 49 forks source link

Try to improve gphoto2 reads #1257

Closed wtgee closed 2 months ago

wtgee commented 2 months ago

The output from the gphoto2 expose command was never being read. This essentially moves the blocking call up to _poll_exposure in the base by using the get_command_result.

Tested on PAN026, where it fixed the problem of multiple exposures failing.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.69%. Comparing base (4ec2240) to head (a777d8f).

:exclamation: Current head a777d8f differs from pull request most recent head e3d41dc. Consider uploading reports for the commit e3d41dc to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1257 +/- ## ======================================== Coverage 71.69% 71.69% ======================================== Files 100 100 Lines 8401 8401 Branches 1165 1165 ======================================== Hits 6023 6023 Misses 2229 2229 Partials 149 149 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.