search

panoptes / panoptes-utils

A set of Astronomical utility functions. PANOPTES style. :hammer_and_wrench: :telescope: :stars:
https://panoptes-utils.readthedocs.io
MIT License
4 stars 9 forks source link

fpack/funpack will overwrite destination by default #175

Closed wtgee closed 4 years ago

wtgee commented 4 years ago

Sadly, this was failing silently, so the file was not overwritten but returning a True value to indicate it was. This was causing the incorrect file to be saved file to not be solved, which leads to the FITS headers being pulled from the old, non-solved file. These old headers were then being written to the new file.

codecov-io commented 4 years ago

Codecov Report

Merging #175 into develop will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
+ Coverage    72.82%   72.88%   +0.06%     
===========================================
  Files           26       26              
  Lines         1803     1807       +4     
  Branches       236      238       +2     
===========================================
+ Hits          1313     1317       +4     
  Misses         429      429              
  Partials        61       61
Impacted Files Coverage Δ
panoptes/utils/images/fits.py 78.86% <100.00%> (+0.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 01c856e...d7ff734. Read the comment docs.