codecov[bot]
commented
3 years ago Codecov Report
Merging #262 (cb9f785) into develop (19cd5b6) will decrease coverage by
6.22%. The diff coverage is14.28%.
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
- Coverage 78.67% 72.44% -6.23%
===========================================
Files 49 33 -16
Lines 3057 2007 -1050
Branches 273 0 -273
===========================================
- Hits 2405 1454 -951
+ Misses 611 553 -58
+ Partials 41 0 -41 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/panoptes/utils/rs232.py | 84.03% <14.28%> (-2.34%) |
:arrow_down: |
| src/panoptes/__init__.py | 100.00% <0.00%> (ø) |
|
| src/panoptes/utils/config/helpers.py | 100.00% <0.00%> (ø) |
|
| tests/test_time.py | ||
| tests/images/test_image_utils.py | ||
| tests/test_rs232.py | ||
| conftest.py | ||
| tests/config/test_config_cli.py | ||
| src/panoptes/utils/theskyx.py | ||
| tests/test_database.py | ||
| ... and 29 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 19cd5b6...cb9f785. Read the comment docs.
This PR adds a new public method called
readlinesthat uses the existing methodread()in a loop so that we can read a buffer when there is more than one line.